Merged
Conversation
rreusser
reviewed
Jul 6, 2017
| var dx = pt1[0] - pt2[0], | ||
| dy = pt1[1] - pt2[1]; | ||
| var dx = pt1[2] - pt2[2], | ||
| dy = pt1[3] - pt2[3]; |
Contributor
There was a problem hiding this comment.
Is 0/1 vs 2/3 the difference between data units and grid index units?
Collaborator
Author
There was a problem hiding this comment.
yes - kinda hacky but since we had this available when calculating the pixel positions I tacked it on.
Contributor
|
Looks good! Thanks for the quick fix 🎉 I can't notice any differences in the updated baseline, except for
If this is expected, 💃 |
Collaborator
Author
|
Yep, the changes are pretty minor - and in fact I notice that the change you highlighted actually swaps one instance of crossing contours for another... so it's basically a wash until we make an altogether different interpolation algorithm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #641
We have a step in contour path creation that coalesces points that are too close together relative to the average distance between points. Without this we can get strange effects at crossings very close to corners of grid cells, but it was implemented in pixel coordinates, which means on nonlinear grids (particularly log axes with zero or negative positions) the threshold was incorrect. Fixed by calculating this threshold in index units.
Some existing mocks changed. Mostly the changes are minor and possibly even improvements. There's a slightly annoying one in
contour_lines_coloring(and the others that use that same data) where it adds a new crossing of some nearby contours with differing topology, but to me that's just increasing our motivation to find an altogether better way to interpolate these curves.@rreusser please review (since hopefully ^^ will land on your plate at some point!)
cc @etpinard